Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssh: bump to 9.9p1 #25011

Merged
merged 1 commit into from
Sep 26, 2024
Merged

openssh: bump to 9.9p1 #25011

merged 1 commit into from
Sep 26, 2024

Conversation

graysky2
Copy link
Contributor

@graysky2 graysky2 commented Sep 22, 2024

Release notes: https://www.openssh.com/txt/release-9.9
Added upstream patch to fix build[1]

  1. https://github.com/openssh/openssh-portable/commit/76a618d2842c34c16cd21a4efc7230e2f459008d.patch

Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne

Maintainer: @SibrenVasse, @tripolar

@BKPepe
Copy link
Member

BKPepe commented Sep 22, 2024

Had to remove the configure option --disable-wtmp to get it to build.

Have you reach upstream to look at it? For me, it looks like, wtmp will be enabled by default. I dont think that we want that. 🤷 Enabling smth by default, it means that there is going to be size difference and if you enabled it, you need to know smth more about wtmp.

@SibrenVasse
Copy link
Contributor

You can fix the compilation with --disable-utmp with this patch
SibrenVasse#30

@graysky2
Copy link
Contributor Author

Thanks @SibrenVasse - your patch fixes the build and everything works as expected on my x86/64 test box.

@BKPepe
Copy link
Member

BKPepe commented Sep 24, 2024

Do you have any build log related to the issue, which you experienced? Isn't it same as openssh/openssh-portable#504 ? Sorry for such questions, but all of this, should be part of the patch, which you adds and also, it should be solved in upstream not in downstream, though.

@graysky2
Copy link
Contributor Author

@BKPepe - see here.

@BKPepe
Copy link
Member

BKPepe commented Sep 26, 2024

I can see that it was solved in upstream: openssh/openssh-portable@76a618d

Could you replace your patch with the upstream one, please?
https://github.com/openssh/openssh-portable/commit/76a618d2842c34c16cd21a4efc7230e2f459008d.patch

Release notes: https://www.openssh.com/txt/release-9.9

Added upstream patch to fix build[1]

1. https://github.com/openssh/openssh-portable/commit/76a618d2842c34c16cd21a4efc7230e2f459008d.patch

Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne

Signed-off-by: John Audia <[email protected]>
@graysky2
Copy link
Contributor Author

Thanks @BKPepe - patch added and refreshed.

@BKPepe BKPepe merged commit b90e9b7 into openwrt:master Sep 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants