nl80211: handle per_sta_vif case properly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
raenye
approved these changes
Jan 6, 2024
|
I refactored this slightly for readability. |
|
@Ansuel I'm sorry for the ping but is there any chance you could look into this? I'd like to use the official image without needing to apply this. If there are any changes I need to make please let me know |
dhewg
suggested changes
Jan 24, 2024
rany2
force-pushed
the
per_sta_vif_fix
branch
from
c421d75
to
c724b77
Compare
1 task
When per_sta_vif is enabled in hostapd BSS config, we need to iterate
through every interface in /sys/class/net which matches
`${interface_requested}.${number}`. Otherwise data requested from iwinfo
will be incomplete/nonexistant. This is already handled for WDS so there is
precedence for a change like this.
Also refactor logic on whether to issue a NL80211_CMD_GET_STATION request
on the interface into a seperate function.
Closes openwrt/openwrt#14339
Signed-off-by: Rany Hany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When per_sta_vif is enabled in hostapd BSS config, we need to iterate
through every interface in /sys/class/net which matches
${interface_requested}.${number}. Otherwise data requested from iwinfowill be incomplete/nonexistant. This is already handled for WDS so there is
precedence for a change like this.
Also refactor logic on whether to issue a NL80211_CMD_GET_STATION request
on the interface into a seperate function.
Closes openwrt/openwrt#14339