Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get demo.py running on MacOS #1105

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Get demo.py running on MacOS #1105

merged 2 commits into from
Aug 20, 2024

Conversation

englehardt
Copy link
Collaborator

@englehardt englehardt commented Aug 9, 2024

A few notes:

  • I was getting errors from mamba about not wanting to overwrite an existing environment. From the docs, I think we intend to, so I've added --force which will overwrite. I'm not sure if this is a platform difference?
  • The firefox binary has changed names on MacOS
  • I've migrated storage_watchdog.py over to python native code. Let's avoid subprocess calls out to system utilities as much as possible. MacOS has independent implementations of the OS utils, often with different options. I was tempted to install gnu-coreutils to fix this, but I'd rather not add another dependency when we can easily do the same calculation in python.

@englehardt englehardt requested a review from vringar August 9, 2024 03:44
@englehardt
Copy link
Collaborator Author

The tests were failing because of the --force option I added. I see in #1088 we removed it intentionally. I probably just have an outdated version of mamba.

But it looking it up, it seems the mamba solver is now used by conda: https://github.com/conda-forge/miniforge?tab=readme-ov-file#whats-the-difference-between-mambaforge-and-miniforge. So we should update https://github.com/openwpm/OpenWPM?tab=readme-ov-file#pre-requisites and the install files to revert back to the latest miniforge.

@englehardt englehardt merged commit 1ac8b64 into master Aug 20, 2024
19 checks passed
@englehardt englehardt deleted the macos-compatibility-fixes branch August 20, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant