Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error response to avoid hanging #2037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ja-bravo
Copy link

This PR updates the access token endpoint so it returns when an error happens, closing the connection.

This fixes a crash when the end user takes a good while to fetch the credential after creating an offer, triggering a ERR_HTTP_HEADERS_SENT: Cannot set headers after they are sent to the client error.

We talked about this before and it was unclear if this change would break anything else but we've been running this successfully for months so I think it's okay.

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 4636a55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue with this approach is that the agent context session won't be closed correctly (which is why we call next().

I think we need to find out what is modifying the response after the error has been sent. Or allow returning early, but still having the afterware called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants