feat: support new didcomm v2 service type #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
🦋 Changeset detectedLatest commit: b09640f The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
genaris
approved these changes
Jun 17, 2024
packages/core/src/modules/dids/domain/service/DidDocumentService.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/dids/domain/service/DidDocumentService.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
…ice type (in addition to older 'DIDComm' service type Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
feat/new-didcomm-v2-service
branch
from
98611da
to
b09640f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1789 and can help in getting #1865 merged.
Adds a new service type for
DIDCommMessaging, which supports the object / array structure. Keeps the existingDidCommV2Serviceto not introduce a breaking change. In the next major version we can rename that toLegacyDidcommV2Serviceand later remote it all together.