Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add sample cdc #1692

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ericvergnaud
Copy link
Contributor

Hi,

contributing to #1638 by providing a working postgres CDC sample that publishes changes to redis.

Not sure how you'd want to provide this in the repo, feel free to move it wherever as required.

@ericvergnaud ericvergnaud requested a review from a team as a code owner January 8, 2024 16:48
@ericvergnaud ericvergnaud changed the title add sample cdc feat: add sample cdc Jan 8, 2024
@ericvergnaud ericvergnaud changed the title feat: add sample cdc feat!: add sample cdc Jan 8, 2024
@TimoGlastra
Copy link
Contributor

Very cool @ericvergnaud! I think it would be great if we can add this to the samples directory and integrate it with an actual AFJ mediator setup as example. We currently have a veryyy simple mediator as example, and then this could be part of a more complex one. Or at some point we can move it to another repo (e.g. combine it with https://github.com/animo/animo-mediator and make that a ready to deploy production ready mediator deploy for which we could publish images to docker)

@ericvergnaud
Copy link
Contributor Author

@TimoGlastra I've moved it under examples.
In order to implement a fully working example, I would need to use #1638 as a basis. Not sure about the best strategy, should I wait for it to be merged or should I create a PR on @genaris's work ?

@ericvergnaud
Copy link
Contributor Author

@TimoGlastra not sure why prettier fails, exit code 1 is not very helpful. How do you run this locally ?

@TimoGlastra
Copy link
Contributor

It lists the files that are not formatted correclty:

samples/postgres-cdc/docker-compose.yml
samples/postgres-cdc/README.md

You can run yarn format locally to fix it

Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
@TimoGlastra
Copy link
Contributor

Sorry for the long delay in getting this addressed @ericvergnaud. We now have https://github.com/sairanjit/credo-ts-examples, which we intend to move over to OWF in the future. Could you add this example to that repository? That would be the perfect place I think. Also I think for this to work you'd also need a custom MessageRepository right? Could you extend the example to be a minimal, but fully working example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants