Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split AFJ demo for two cases: Main and DidCommV2 #1470

Open
wants to merge 5 commits into
base: feat/didcomm-v2
Choose a base branch
from

Conversation

Artemkaaas
Copy link
Contributor

Started work on splitting the Alice/Faber demo into smaller cases. Using this we can add demos for various optional modules.

  • Main - general demo of issuing credentials and presenting the proof
  • DidComm V2 - demo reflecting supported didcomm v2 protocols

@Artemkaaas Artemkaaas requested a review from a team as a code owner May 26, 2023 08:42
@TimoGlastra
Copy link
Contributor

I think overall LGTM. I'm not sure though on splitting it up. What if we add an option to create a v1 or v2 invitation? And on the other side we just do receive invitation and it will accept both?

I think an agent should be able to run both at the same time, so I don't see a specific reason to split it up

@Artemkaaas
Copy link
Contributor Author

I think overall LGTM. I'm not sure though on splitting it up. What if we add an option to create a v1 or v2 invitation? And on the other side we just do receive invitation and it will accept both?

I think an agent should be able to run both at the same time, so I don't see a specific reason to split it up

What if we add an option to create a v1 or v2 invitation? And on the other side we just do receive invitation and it will accept both?

This is how it's currently done in hyperledger:feat/didcomm-v2.
I thought of splitting the main demo into independent cases so that we can create demos for conflicting cases such as: indy/askar wallets, indy/cheqd ledgers, cl/w3c credentials etc...

@TimoGlastra
Copy link
Contributor

Discussed on AFJ WG call. It's okay to split up the demo.

@TimoGlastra TimoGlastra added this to the 0.6 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants