Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flakey firewall check #1284

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Oct 10, 2024

Summary of Changes

The firewall check if flakey at best because of it drawing on the genesis transactions which may or may not (most likley not) represent existing nodes. Because its so hit and miss we elected to just remove it.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jleach jleach self-assigned this Oct 10, 2024
@jleach jleach added do not merge Don't merge when label present and removed do not merge Don't merge when label present labels Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@jleach jleach marked this pull request as draft October 10, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant