chore: rename HeaderButton into IconButton #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-mcmath
requested changes
Oct 4, 2024
jleach
previously approved these changes
Oct 4, 2024
|
If you want to specify the ticket number and it's not in this repo you need to use the format bcgov/bc-wallet-mobile#1093. Just adding #nnnn will reference the wrong ticket. |
tom11-nguyen
changed the title
added 2 commits
October 10, 2024 09:42
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]>
tom11-nguyen
force-pushed
the
chore/rename-header-btn
branch
from
903e392
to
4727947
Compare
|
al-rosenthal
pushed a commit
to al-rosenthal/bifold-wallet
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Nguyen, Tom CITZ:EX <[email protected]> Co-authored-by: Nguyen, Tom CITZ:EX <[email protected]> Signed-off-by: al-rosenthal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This change renames the HeaderButton component in core/App/components to name: IconButton, including file names and usages.
Related Issues
bcgov/bc-wallet-mobile#1807
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.