This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
Add index db wrapper #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
commented
Dec 7, 2022
OR13
commented
Dec 7, 2022
OR13
commented
Dec 7, 2022
OR13
commented
Dec 7, 2022
OR13
commented
Dec 7, 2022
OR13
commented
Dec 7, 2022
OR13
commented
Dec 7, 2022
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
Signed-off-by: Orie Steele <[email protected]>
OR13
force-pushed
the
feat/add-indexdb-wrapper
branch
from
959c4df
to
51c70cd
Compare
|
What is the LICENSE for the Gladstone source files? Can we include a LICENSE file in web-platform-core/Gladstone and possibly SPDX short identifiers in the source files? |
|
@tkuhrt it is Apache 2.0, can you suggest the changes you want to see, so I can approve / merge them? |
tkuhrt
reviewed
Jan 9, 2023
| @@ -0,0 +1,81 @@ | |||
| const gladstone = (database = 'Gladstone') => { | |||
There was a problem hiding this comment.
Suggested change
| const gladstone = (database = 'Gladstone') => { | |
| // SPDX-License-Identifier: Apache-2.0 | |
| const gladstone = (database = 'Gladstone') => { |
There was a problem hiding this comment.
The above should be good enough. I see that we have a LICENSE file at the root of this repo, which should cover this folder, as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Orie Steele [email protected]