Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passwdqc: Remove relative path #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rprasanth
Copy link

using relative paths causes issues with symlink
we can install and make a symlink in the same directory "/usr/lib"

using relative paths causes issues with symlink
we can install and make a symlink in the same directory "/usr/lib"
Copy link
Collaborator

@ldv-alt ldv-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this breaks setups when SHARED_LIBDIR != DEVEL_LIBDIR.
You can omit the relative part if and only if SHARED_LIBDIR == DEVEL_LIBDIR.

@rprasanth
Copy link
Author

Sorry, I didn't get the scenario of SHARED_LIBDIR & DEVEL_LIBDIR, where it gonna break?

Despite, is there any specific reason for having the libpasswdqc.so.1 in /usr/lib and making a smylink libpasswdqc.so in /lib?

@solardiz
Copy link
Member

using relative paths causes issues with symlink

What issues?

@rprasanth
Copy link
Author

in my case, I maintain a toolchain directory where /usr was symlinked to the (.) current directory.
In other cases like yocto buildsystem rootfilesystem can be made to use the symlink of /usr location to others. In that case, it fails.
That's the reason, I made the change to have the library and its symlink in the same location.

@rprasanth
Copy link
Author

Hi, any update on merge!

@solardiz
Copy link
Member

solardiz commented Jan 6, 2022

@rprasanth This should not be merged as-is because it breaks setups when SHARED_LIBDIR != DEVEL_LIBDIR, and because it uses DEVEL_LIBDIR inconsistently with its name. We do not currently have an obviously better/proper fix. Do you?

@solardiz
Copy link
Member

@rprasanth I think a better fix would be to make the ln change conditional upon SHARED_LIBDIR and DEVEL_LIBDIR being the same (otherwise use our current ln invocation with relative path). Can you please implement that and force-push to this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants