[AUTO] Fix the timing issue in AUTO inference #27290
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: AUTO
…into ywang2/fix_the_timing_issue
yangwang201911
changed the title
songbell
reviewed
Dec 4, 2024
src/plugins/auto/src/schedule.cpp
Outdated
| std::unique_lock<std::mutex> lck(worker_infer_mutex); | ||
| if (!idle_workerrequests.try_pop(worker)) { | ||
| idle_workerrequests_cv.wait(lck, [&idle_workerrequests, &worker] { | ||
| return idle_workerrequests.try_pop(worker); |
There was a problem hiding this comment.
overall, this solution seems to wait forever until it can get a worker, this is not by design(by design we have m_infer_pipeline_tasks for tasks which are not able to schedule workers at some moment).
maybe we can consider increase cpu worker infer request to 2 to avoid this deadlock, or if we need to use cv to fix this issue, at least can we try align with the m_infer_pipeline_tasks design?
songbell
reviewed
Dec 4, 2024
| // This is necessary to handle the case where a request worker is popped from the idle queue before being pushed back. | ||
| // Without at least 2 requests, there could be a situation where no requests are available for inference, | ||
| // leading to potential deadlocks. | ||
| num_requests = num_requests <= 1 ? 2 : num_requests; |
There was a problem hiding this comment.
let's trigger local CI tests for auto to ensure no regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: