Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STFT][CPU] Improve performance of STFT for CPU by reusage RDFT jit Executor #26967

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[STFT][CPU] Improve performance of STFT for CPU by reusage RDFT jit Executor #26967

wants to merge 15 commits into from
+397 −227

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Oct 9, 2024 •
edited
Loading

Details:

  • Improve performance of STFT for CPU plugin by reusage RDFT jit Executor
  • No changes in the logic of the existing RDFT executor, it has been just moved to rdft.h to enable reusage in stft

Tickets:

  • 156115

@mitruska mitruska self-assigned this Oct 9, 2024
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: TEMPLATE OpenVINO Template plugin labels Oct 9, 2024
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Oct 18, 2024
@mitruska mitruska changed the title [WIP] Enable STFT impl for CPU plugin [WIP] Enable STFT impl for CPU plugin by RDFT Executor Oct 18, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Stale label Nov 17, 2024
praasz
praasz reviewed Nov 18, 2024
View reviewed changes
src/core/shape_inference/include/stft_shape_inference.hpp Outdated
}

const auto& frame_size_val = (*frame_size)[0];
const auto& frame_step_val = (*frame_step)[0];

NODE_SHAPE_INFER_CHECK(op,
input_shapes,
0 < frame_size_val && frame_size_val < signal_shape[1].get_interval().get_max_val(),
0 < frame_size_val && (signal_shape[1].is_static()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check:
If single_shapep[1] is 1 and frame_size_val is one also the check will fail but in error message there will be
... size is 1 but must be in range [1, 1]

Also check check the error message as signal_shape[1] can also be interval value and then in message can be:
in range [1, (2,3)]

@github-actions github-actions bot removed the Stale label Nov 19, 2024
@github-actions github-actions bot removed category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common labels Nov 29, 2024
@github-actions github-actions bot removed the category: TEMPLATE OpenVINO Template plugin label Dec 3, 2024
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Dec 11, 2024
@mitruska mitruska marked this pull request as ready for review December 11, 2024 12:14
@mitruska mitruska requested review from a team as code owners December 11, 2024 12:14
@mitruska mitruska changed the title [WIP] Enable STFT impl for CPU plugin by RDFT Executor [STFT][CPU] Improve performance of STFT for CPU by reusage RDFT jit Executor Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mitruska mitruska

Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitruska @praasz