This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Enable type checks #208
Draft
Enable type checks #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sovrasov FYI |
added 2 commits
October 18, 2021 15:21
druzhkov-paul
commented
Oct 18, 2021
| @@ -53,7 +53,7 @@ def DATASET_PARAMETERS_FIELDS(): | |||
| ) | |||
|
|
|||
| ROOT_PATH_KEY = '_root_path' | |||
| DatasetParameters = namedtuple('DatasetParameters', DATASET_PARAMETERS_FIELDS()) | |||
| DatasetParameters = namedtuple('DatasetParameters', DATASET_PARAMETERS_FIELDS()) # type: ignore | |||
There was a problem hiding this comment.
@LeonidBeynenson Please note.
druzhkov-paul
commented
Oct 18, 2021
| @@ -10,7 +10,7 @@ | |||
| _e2e_pytest_addoption = None | |||
| pass | |||
|
|
|||
| import config | |||
| import e2e_config | |||
There was a problem hiding this comment.
@LeonidBeynenson Please note.
druzhkov-paul
commented
Oct 18, 2021
| @@ -183,7 +183,7 @@ def save_model(self, output_model: ModelEntity): | |||
| hyperparams_str = ids_to_strings(cfg_helper.convert(hyperparams, dict, enum_to_str=True)) | |||
| labels = {label.name: label.color.rgb_tuple for label in self._labels} | |||
| modelinfo = { | |||
| 'compression_state': self._compression_ctrl.get_compression_state(), | |||
| 'compression_state': self._compression_ctrl.get_compression_state(), # type: ignore # FIXME. | |||
There was a problem hiding this comment.
@AlexanderDokuchaev Please note.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build 302