Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to calculator docs #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

updates to calculator docs #56

wants to merge 2 commits into from

Conversation

dtrawins
Copy link
Collaborator

No description provided.

Comment on lines 32 to +34
optional string server_config = 4;
// model server config.json path must be identical in all calculators used in the graph
// when the graph is deployed in the OVMS, server_config param is not needed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
optional string server_config = 4;
// model server config.json path must be identical in all calculators used in the graph
// when the graph is deployed in the OVMS, server_config param is not needed.
// model server config.json path must be identical in all calculators used in the graph
// when the graph is deployed in the OVMS, server_config param is not needed.
optional string server_config = 4;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move comment before the line being commented.

Copy link
Collaborator

@atobiszei atobiszei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside 1 remark LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants