Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for release 1.4 #1106

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Update for release 1.4 #1106

merged 3 commits into from
Jul 20, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Jul 19, 2023

Summary

  • update for release 1.4.0
  • update changelog
  • update release note

@yunchu yunchu changed the base branch from develop to releases/1.4.0 July 19, 2023 23:55
@yunchu yunchu marked this pull request as ready for review July 20, 2023 00:00
@yunchu yunchu requested review from a team as code owners July 20, 2023 00:00
@yunchu yunchu requested review from jihyeonyi and removed request for a team July 20, 2023 00:00
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog should be updated

@yunchu yunchu force-pushed the infra/update-for-release-1.4 branch from 0c44ca6 to 24c55fe Compare July 20, 2023 01:28
@yunchu
Copy link
Contributor Author

yunchu commented Jul 20, 2023

@wonjuleee @vinnamkim please check the PR description. it's not ready to get review yet. just opened to check coverage reporting.

@yunchu yunchu force-pushed the infra/update-for-release-1.4 branch from 24c55fe to 544f450 Compare July 20, 2023 01:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (releases/1.4.0@6a612ef). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.4.0    #1106   +/-   ##
=================================================
  Coverage                  ?   79.99%           
=================================================
  Files                     ?      257           
  Lines                     ?    29031           
  Branches                  ?     5689           
=================================================
  Hits                      ?    23224           
  Misses                    ?     4478           
  Partials                  ?     1329           
Flag Coverage Δ
macos-11_Python-3.8 79.08% <0.00%> (?)
ubuntu-20.04_Python-3.8 79.97% <0.00%> (?)
windows-2019_Python-3.8 79.91% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1 +1 @@
__version__ = "1.4.0"
__version__ = "1.4.0rc4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct? rc4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a final RC, rc4 will be published to pypi and verified it with Geti & OTX. after then I will be published as 1.4.0.

src/datumaro/version.py Show resolved Hide resolved
@yunchu yunchu merged commit ebdfc6c into releases/1.4.0 Jul 20, 2023
4 of 7 checks passed
@yunchu yunchu deleted the infra/update-for-release-1.4 branch August 29, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants