Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaulting convert_ucsc_contig_names to True for consistency with past behavior #253

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Defaulting convert_ucsc_contig_names to True for consistency with past behavior #253

merged 1 commit into from
Jul 3, 2024

Conversation

julia326
Copy link
Contributor

@julia326 julia326 commented Jul 3, 2024

No description provided.

@julia326 julia326 requested a review from iskandr July 3, 2024 15:57
@iskandr
Copy link
Contributor

iskandr commented Jul 3, 2024

👍 once tests pass

@coveralls
Copy link

Coverage Status

coverage: 88.33% (-6.4%) from 94.753%
when pulling f07a8e2 on default-ucsc-contig-rename-true
into ef6249c on main.

@iskandr
Copy link
Contributor

iskandr commented Jul 3, 2024

@julia326 Noting that coveralls probably needs to be configured for parallel jobs but still merging this

@iskandr iskandr merged commit 2c1c96e into main Jul 3, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskandr iskandr iskandr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julia326 @iskandr @coveralls