Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explainer with button behaviors #1125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mfreed7
Copy link
Collaborator

@mfreed7 mfreed7 commented Nov 8, 2024

Also remove the split button section.

@mfreed7 mfreed7 marked this pull request as ready for review November 8, 2024 21:10
Copy link

@aleventhal aleventhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to say anything about, the button needs to be the first child element of the select and no other buttons in the select participate this way?

@mfreed7
Copy link
Collaborator Author

mfreed7 commented Nov 8, 2024

Do we need to say anything about, the button needs to be the first child element of the select and no other buttons in the select participate this way?

Is this a requirement?

@scottaohara
Copy link
Collaborator

having the button part being actually inert won't cause any issues in calculating the value of the select, will it?

as we had previously resolved that if someone were to do:

<select>
  <button> foo <selectedcontent>bar <span class="hide">baz</span></selectedcontent></button>
  <option selected>bar <span class="hide">baz</span></option>
</select>

<style>
  selectedcontent .hide { display: none }
</style>

that the value for the select would be returned as "foo bar" instead of the option's "bar baz" text

@aleventhal
Copy link

aleventhal commented Nov 11, 2024 via email

@aleventhal
Copy link

aleventhal commented Nov 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants