CONTRIB: Fixed typo in env var for cuda_hooks gtest. #10239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyastreb
previously approved these changes
Oct 18, 2024
brminich
previously approved these changes
Oct 18, 2024
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yosefe
approved these changes
Oct 18, 2024
yosefe
requested changes
Oct 18, 2024
contrib/test_jenkins.sh
Outdated
| @@ -878,7 +878,7 @@ run_malloc_hook_gtest() { | |||
|
|
|||
| echo "==== Running cuda hooks with far jump, $compiler_name compiler ====" | |||
| $TIMEOUT env \ | |||
| UCM_BISTRO_FORCE_FAR_JUMP=y \ | |||
| UCX_BISTRO_FORCE_FAR_JUMP=y \ | |||
There was a problem hiding this comment.
i think it should be UCX_MEM_BISTRO_FORCE_FAR_JUMP=y
$ ./build-devel/src/tools/info/ucx_info -c|grep BIST
UCX_MEM_BISTRO_FORCE_FAR_JUMP=n
There was a problem hiding this comment.
Yes, you're right.
Force-pushed the change since it is one line commit.
rakhmets
force-pushed
the
topic/typo-cuda-hooks-test
branch
from
6822b54
to
e73d190
Compare
brminich
approved these changes
Oct 18, 2024
yosefe
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed typo in env var for cuda_hooks gtest.