GTEST/UCT: Add ability to filter by resource or md name #10205
Conversation
test/gtest/uct/test_md.cc
Outdated
|
|
||
| std::vector<test_md_param> result; | ||
| for (std::vector<md_resource>::iterator iter = md_resources.begin(); | ||
| iter != md_resources.end(); ++iter) { | ||
| if (iter->cmpt_attr.name == cmpt_name) { | ||
| if ((iter->cmpt_attr.name == cmpt_name) && | ||
| ((md_name == "") || (md_name == iter->rsc_desc.md_name))) { |
There was a problem hiding this comment.
minor: more C++ idiomatic way of checking empty string:
md_name.empty()
test/gtest/uct/uct_test.cc
Outdated
| @@ -461,6 +468,10 @@ std::vector<const resource*> uct_test::enum_resources(const std::string& tl_name | |||
| ucs_async_context_destroy(async); | |||
| } | |||
|
|
|||
| if (all_resources.size() == 0) { | |||
There was a problem hiding this comment.
| if (all_resources.size() == 0) { | |
| if (all_resources.empty()) { |
tvegas1
force-pushed
the
gtest_uct_filter_md_rsc
branch
from
cee33df
to
7e22c37
Compare
| @@ -461,6 +468,10 @@ std::vector<const resource*> uct_test::enum_resources(const std::string& tl_name | |||
| ucs_async_context_destroy(async); | |||
| } | |||
|
|
|||
| if (all_resources.empty()) { | |||
| UCS_TEST_ABORT("Could not add any resource"); | |||
There was a problem hiding this comment.
why needed? do we want to force failure when some resources not found?
There was a problem hiding this comment.
after adding that filtering, I want to make sure we have at least one interface, to in usability as we cannot run test without any resource, and we get crash otherwise.
The focus is for UCT for EFA, on UCP tests would less be instantiated per md/rsc, and we need to see lanes as they will be used. It's always possible to add UCX_NET_DEVICES if needed. |
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What
Add ability to limit gtest runs by MD and RSC name.
Why ?
Shorten test time on systems with 30+ interfaces.
How ?
Do it from gtest test instantiation, as
UCX_NET_DEVICESis inoperent.