CONTRIB: Add checking script before push #10203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminich
reviewed
Oct 10, 2024
contrib/gitready.sh
Outdated
| git add -p | ||
| # returns 1 if cached index is not empty | ||
| git diff --cached --exit-code || git commit -m "$title" | ||
| git reset --hard |
There was a problem hiding this comment.
why is it needed? Don't we expect that there are no any uncommited changes at this stage?
There was a problem hiding this comment.
while handling git add -p it might be that we did not stage all buffers, hence the cleaning of the remaining changes before doing the same for spellcheck.
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yosefe
reviewed
Oct 17, 2024
fixed, i guess before final merge and after approve/squash, it would be good that I trigger one commit title failure and one spellcheck failure. |
|
/azp run UCX PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Shell script to perform simple preliminary checks before pushing.
Why ?
Avoid spending CI cycles with repeated pushing.
How ?
Implement commit title, code format and spell checks locally. Ran
shellcheckon it.