Merge pull request #536 from opentripplanner/dev

OTP-RR Version 4.0

.github/workflows/node-ci.yml

@@ -23,11 +23,17 @@ jobs:
         uses: bahmutov/npm-install@v1
       - name: Copy example config
         run: cp example-config.yml config.yml
-        # Actual lint step temporarily removed to allow for package release
+      - name: Lint code
+        # Move everything from latest commit back to staged
+        run: git reset --soft HEAD^ && yarn lint
+        # For our info, lint all files but don't mark them as failure
+        # TODO: remove this once project is typescripted
       - name: Lint all code (ignoring errors)
         run: yarn lint-all || true
+      - name: Run type check
+        run: yarn typecheck
       - name: Run tests
-        run: yarn jest
+        run: yarn unit
       - name: Build example project
         run: yarn build
       - name: Run a11y tests

CHANGELOG.md

@@ -0,0 +1,74 @@
+# Open Trip Planner - React Redux Changelog
+
+## [3.0.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.0.0) (2021-04-13)
+
+- Add mobile batch results screen
+- User Account Settings
+- Add more buttons to favorites management
+- Re-organize user settings
+- Add field trip module
+
+## [3.1.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.1.0) (2021-07-07)
+
+- Add reverse directions button
+- Add mailables submodule to calltaker module
+- Improve map performance
+
+## [3.2.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.2.0) (2021-07-15)
+
+- Add GTFS-RT vehicle overlay
+- Add user language settings
+- Support overriding strings
+
+## [3.3.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.3.0) (2021-07-22)
+
+- Field trip module
+  - Add save button
+  - Add delete button
+  - Allow configuration of capacity
+
+## [3.4.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.4.0) (2021-08-18)
+
+- Add automatic a11y compliance tests
+- Adjust colors to conform with [Web Content Accessibility Guidelines](https://www.w3.org/WAI/standards-guidelines/wcag/).
+
+## [3.5.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.5.0) (2021-10-05)
+
+- Add Traveler Tools Menu
+- Add Route Details Viewer
+- Move route viewer to title bar
+- Add support for displaying realtime vehicle positions
+- Support filtering routes by agency or mode
+
+## [3.6.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.6.0) (2021-10-21)
+
+- Further replace colors with accessible ones
+- Add nearby amenities panel to stop viewer
+- Add support for Local Places Index
+
+## [3.7.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.7.0) (2021-11-12)
+
+- Fix reported crashes
+- Zoom to stop when opening stop viewer
+- Display search results based on geolocation
+- New stop markers on map at high zoom levels
+- Add accessibility labels to legs and itineraries when accessible routing is enabled
+- Support showing multiple fare prices
+
+## [3.8.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v3.8.0) (2021-12-16)
+
+- Fix crashes reported to us
+- Improve screen reader experience
+- Add user setting for planning accessible trips by default
+- Support internationalization of most components
+
+## [4.0.0](https://github.com/opentripplanner/otp-react-redux/releases/tag/v4.0.0) (2022-02-10)
+
+- Migrate to webpack-based build system
+- Enhance rendering of flex routes
+- Clean up and modernize call taker interface
+- Internationalize and modernize codebase of `trip-form` component
+- Internationalize `location-field` component
+- GTFS Flex support in stop viewer, route viewer, and trip viewer
+- Improve styling of batch itinerary viewer
+- Support showing recently searched and saved places in main panel

README.md

@@ -21,7 +21,7 @@ yarn start
 Should you want to maintain multiple configuration files, OTP-RR can be made to use a custom config file by using environment variables. Other environment variables also exist. `CUSTOM_CSS` can be used to point to a css file to inject, and `JS_CONFIG` can be used to point to a `config.js` file to override the one shipped with OTP-RR.
 
 ```bash
-yarn start --env.YAML_CONFIG=/absolute/path/to/config.yml
+env YAML_CONFIG=/absolute/path/to/config.yml yarn start
 ```
 
 ## Deploying the UI
@@ -31,7 +31,7 @@ Build the js/css bundle by running `yarn build`. The build will appear in the `d
 The same environment variables which affect the behavior of `yarn start` also affect `yarn build`. Running the following command builds OTP-RR with customized js and css:
 
 ```bash
-yarn build --env.JS_CONFIG=my-custom-js.js env.CUSTOM_CSS=my-custom-css.css
+env JS_CONFIG=my-custom-js.js CUSTOM_CSS=my-custom-css.css yarn build
 ```
 
 ## Library Documentation

__tests__/actions/__snapshots__/api.js.snap

@@ -23,7 +23,7 @@ Array [
   Array [
     Object {
       "payload": Object {
-        "requestId": "abcd1238",
+        "requestId": "abcd1237",
         "response": Object {
           "fake": "response",
         },
@@ -32,17 +32,6 @@ Array [
       "type": "ROUTING_RESPONSE",
     },
   ],
-  Array [
-    Object {
-      "payload": Object {
-        "error": [TypeError: Cannot read properties of undefined (reading 'trackRecent')],
-        "requestId": "abcd1239",
-        "searchId": "abcd1234",
-        "url": "http://mock-host.com:80/api/plan?fromPlace=Origin%20%2812%2C34%29%3A%3A12%2C34&toPlace=Destination%20%2834%2C12%29%3A%3A34%2C12&mode=WALK%2CTRANSIT&ignoreRealtimeUpdates=false&batchId=abcd1234",
-      },
-      "type": "ROUTING_ERROR",
-    },
-  ],
   Array [
     [Function],
   ],
@@ -52,7 +41,7 @@ Array [
         "activeItinerary": 0,
         "pending": 1,
         "routingType": "ITINERARY",
-        "searchId": "abcd1237",
+        "searchId": "abcd1236",
         "updateSearchInReducer": false,
       },
       "type": "ROUTING_REQUEST",
@@ -65,9 +54,9 @@ Array [
     Object {
       "payload": Object {
         "error": [Error: Received error from server],
-        "requestId": "abcd1240",
-        "searchId": "abcd1237",
-        "url": "http://mock-host.com:80/api/plan?fromPlace=Origin%20%2812%2C34%29%3A%3A12%2C34&toPlace=Destination%20%2834%2C12%29%3A%3A34%2C12&mode=WALK%2CTRANSIT&ignoreRealtimeUpdates=false&batchId=abcd1237",
+        "requestId": "abcd1238",
+        "searchId": "abcd1236",
+        "url": "http://mock-host.com:80/api/plan?fromPlace=Origin%20%2812%2C34%29%3A%3A12%2C34&toPlace=Destination%20%2834%2C12%29%3A%3A34%2C12&mode=WALK%2CTRANSIT&ignoreRealtimeUpdates=false&batchId=abcd1236",
       },
       "type": "ROUTING_ERROR",
     },
@@ -107,17 +96,6 @@ Array [
       "type": "ROUTING_RESPONSE",
     },
   ],
-  Array [
-    Object {
-      "payload": Object {
-        "error": [TypeError: Cannot read properties of undefined (reading 'trackRecent')],
-        "requestId": "abcd1236",
-        "searchId": "abcd1234",
-        "url": "http://mock-host.com:80/api/plan?fromPlace=Origin%20%2812%2C34%29%3A%3A12%2C34&toPlace=Destination%20%2834%2C12%29%3A%3A34%2C12&mode=WALK%2CTRANSIT&ignoreRealtimeUpdates=false&batchId=abcd1234",
-      },
-      "type": "ROUTING_ERROR",
-    },
-  ],
 ]
 `;
 

__tests__/components/viewers/__snapshots__/stop-viewer.js.snap

@@ -24,7 +24,7 @@ exports[`components > viewers > stop viewer should render countdown times after
   >
     <Connect(injectIntl(StopViewer))>
       <injectIntl(StopViewer)
-        autoRefreshStopTimes={true}
+        enableFavoriteStops={false}
         favoriteStops={Array []}
         fetchStopInfo={[Function]}
         findStopTimesForStop={[Function]}
@@ -218,7 +218,7 @@ exports[`components > viewers > stop viewer should render countdown times after
         zoomToStop={[Function]}
       >
         <StopViewer
-          autoRefreshStopTimes={true}
+          enableFavoriteStops={false}
           favoriteStops={Array []}
           fetchStopInfo={[Function]}
           findStopTimesForStop={[Function]}
@@ -780,7 +780,6 @@ exports[`components > viewers > stop viewer should render countdown times after
                   className="sc-crrszt jgWhKL"
                 >
                   <LiveStopTimes
-                    autoRefreshStopTimes={true}
                     findStopTimesForStop={[Function]}
                     homeTimezone="America/Los_Angeles"
                     setHoveredStop={[Function]}
@@ -1487,7 +1486,6 @@ exports[`components > viewers > stop viewer should render countdown times after
                             className="sc-dlfnuX jzpRQX"
                           >
                             <input
-                              checked={true}
                               name="autoUpdate"
                               onChange={[Function]}
                               type="checkbox"
@@ -2395,7 +2393,7 @@ exports[`components > viewers > stop viewer should render countdown times for st
   >
     <Connect(injectIntl(StopViewer))>
       <injectIntl(StopViewer)
-        autoRefreshStopTimes={true}
+        enableFavoriteStops={false}
         favoriteStops={Array []}
         fetchStopInfo={[Function]}
         findStopTimesForStop={[Function]}
@@ -2490,7 +2488,7 @@ exports[`components > viewers > stop viewer should render countdown times for st
         zoomToStop={[Function]}
       >
         <StopViewer
-          autoRefreshStopTimes={true}
+          enableFavoriteStops={false}
           favoriteStops={Array []}
           fetchStopInfo={[Function]}
           findStopTimesForStop={[Function]}
@@ -2953,7 +2951,6 @@ exports[`components > viewers > stop viewer should render countdown times for st
                   className="sc-crrszt jgWhKL"
                 >
                   <LiveStopTimes
-                    autoRefreshStopTimes={true}
                     findStopTimesForStop={[Function]}
                     homeTimezone="America/Los_Angeles"
                     setHoveredStop={[Function]}
@@ -3381,7 +3378,6 @@ exports[`components > viewers > stop viewer should render countdown times for st
                             className="sc-dlfnuX jzpRQX"
                           >
                             <input
-                              checked={true}
                               name="autoUpdate"
                               onChange={[Function]}
                               type="checkbox"
@@ -3893,7 +3889,7 @@ exports[`components > viewers > stop viewer should render times after midnight w
   >
     <Connect(injectIntl(StopViewer))>
       <injectIntl(StopViewer)
-        autoRefreshStopTimes={true}
+        enableFavoriteStops={false}
         favoriteStops={Array []}
         fetchStopInfo={[Function]}
         findStopTimesForStop={[Function]}
@@ -4087,7 +4083,7 @@ exports[`components > viewers > stop viewer should render times after midnight w
         zoomToStop={[Function]}
       >
         <StopViewer
-          autoRefreshStopTimes={true}
+          enableFavoriteStops={false}
           favoriteStops={Array []}
           fetchStopInfo={[Function]}
           findStopTimesForStop={[Function]}
@@ -4649,7 +4645,6 @@ exports[`components > viewers > stop viewer should render times after midnight w
                   className="sc-crrszt jgWhKL"
                 >
                   <LiveStopTimes
-                    autoRefreshStopTimes={true}
                     findStopTimesForStop={[Function]}
                     homeTimezone="America/Los_Angeles"
                     setHoveredStop={[Function]}
@@ -5367,7 +5362,6 @@ exports[`components > viewers > stop viewer should render times after midnight w
                             className="sc-dlfnuX jzpRQX"
                           >
                             <input
-                              checked={true}
                               name="autoUpdate"
                               onChange={[Function]}
                               type="checkbox"
@@ -6275,7 +6269,7 @@ exports[`components > viewers > stop viewer should render with OTP transit index
   >
     <Connect(injectIntl(StopViewer))>
       <injectIntl(StopViewer)
-        autoRefreshStopTimes={true}
+        enableFavoriteStops={false}
         favoriteStops={Array []}
         fetchStopInfo={[Function]}
         findStopTimesForStop={[Function]}
@@ -6727,7 +6721,7 @@ exports[`components > viewers > stop viewer should render with OTP transit index
         zoomToStop={[Function]}
       >
         <StopViewer
-          autoRefreshStopTimes={true}
+          enableFavoriteStops={false}
           favoriteStops={Array []}
           fetchStopInfo={[Function]}
           findStopTimesForStop={[Function]}
@@ -7547,7 +7541,6 @@ exports[`components > viewers > stop viewer should render with OTP transit index
                   className="sc-crrszt jgWhKL"
                 >
                   <LiveStopTimes
-                    autoRefreshStopTimes={true}
                     findStopTimesForStop={[Function]}
                     homeTimezone="America/Los_Angeles"
                     setHoveredStop={[Function]}
@@ -9815,7 +9808,6 @@ exports[`components > viewers > stop viewer should render with OTP transit index
                             className="sc-dlfnuX jzpRQX"
                           >
                             <input
-                              checked={true}
                               name="autoUpdate"
                               onChange={[Function]}
                               type="checkbox"
@@ -11755,7 +11747,7 @@ exports[`components > viewers > stop viewer should render with TriMet transit in
   >
     <Connect(injectIntl(StopViewer))>
       <injectIntl(StopViewer)
-        autoRefreshStopTimes={true}
+        enableFavoriteStops={false}
         favoriteStops={Array []}
         fetchStopInfo={[Function]}
         findStopTimesForStop={[Function]}
@@ -12202,7 +12194,7 @@ exports[`components > viewers > stop viewer should render with TriMet transit in
         zoomToStop={[Function]}
       >
         <StopViewer
-          autoRefreshStopTimes={true}
+          enableFavoriteStops={false}
           favoriteStops={Array []}
           fetchStopInfo={[Function]}
           findStopTimesForStop={[Function]}
@@ -13017,7 +13009,6 @@ exports[`components > viewers > stop viewer should render with TriMet transit in
                   className="sc-crrszt jgWhKL"
                 >
                   <LiveStopTimes
-                    autoRefreshStopTimes={true}
                     findStopTimesForStop={[Function]}
                     homeTimezone="America/Los_Angeles"
                     setHoveredStop={[Function]}
@@ -13988,7 +13979,6 @@ exports[`components > viewers > stop viewer should render with TriMet transit in
                             className="sc-dlfnuX jzpRQX"
                           >
                             <input
-                              checked={true}
                               name="autoUpdate"
                               onChange={[Function]}
                               type="checkbox"
@@ -15908,7 +15898,7 @@ exports[`components > viewers > stop viewer should render with initial stop id a
   >
     <Connect(injectIntl(StopViewer))>
       <injectIntl(StopViewer)
-        autoRefreshStopTimes={true}
+        enableFavoriteStops={false}
         favoriteStops={Array []}
         fetchStopInfo={[Function]}
         findStopTimesForStop={[Function]}
@@ -15937,7 +15927,7 @@ exports[`components > viewers > stop viewer should render with initial stop id a
         zoomToStop={[Function]}
       >
         <StopViewer
-          autoRefreshStopTimes={true}
+          enableFavoriteStops={false}
           favoriteStops={Array []}
           fetchStopInfo={[Function]}
           findStopTimesForStop={[Function]}