-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(site): fix site api table style #2507
Conversation
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
examples/sites/src/views/components/components.vue (1)
871-880
: Consider enhancing mobile responsiveness.While the current styles fix the table layout issues, consider adding responsive breakpoints for better mobile support:
.api-table-box { border-left: 1px solid rgb(239, 239, 245); border-right: 1px solid rgb(239, 239, 245); overflow-x: auto; width: 100%; + @media (max-width: 767px) { + margin: 0 -16px; /* Negative margin to allow full-width scrolling */ + width: calc(100% + 32px); + } } .api-table { width: 100%; min-width: 640px; table-layout: fixed; border-collapse: collapse; }This enhancement will:
- Allow the table to scroll horizontally on mobile devices
- Prevent content from being cut off at the edges
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
examples/sites/package.json
(1 hunks)examples/sites/src/views/components/components.vue
(6 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/sites/package.json
🔇 Additional comments (2)
examples/sites/src/views/components/components.vue (2)
39-94
: LGTM: Improved API table structure with consistent wrapper.
The addition of the api-table-box
wrapper provides better visual containment and overflow handling for the API tables.
161-229
: LGTM: Consistent API table structure maintained.
The wrapper implementation is consistently applied across different sections, maintaining a uniform layout structure.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Style