Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RTT cli #628

Merged
merged 6 commits into from
Oct 21, 2023
Merged

Add support for RTT cli #628

merged 6 commits into from
Oct 21, 2023

Conversation

CodingRays
Copy link
Contributor

Adds support for openthread/openthread#9148

@jwhui jwhui requested a review from LuDuda August 16, 2023 15:46
Copy link
Member

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one change requested.

src/src/system.c Outdated Show resolved Hide resolved
Copy link
Member

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/src/system.c Outdated Show resolved Hide resolved
@CodingRays
Copy link
Contributor Author

So there might be an issue with the tests. I forgot to add the uart_rtt.h include and the tests generated a warning for it, however it did not cause them to fail.

@jwhui jwhui merged commit 9af899e into openthread:main Oct 21, 2023
7 checks passed
@CodingRays CodingRays deleted the rtt_cli branch October 25, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants