Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[script] fix incorrect package name for brew bootstrap #957

Merged
merged 1 commit into from
Aug 31, 2024
Merged

[script] fix incorrect package name for brew bootstrap #957

merged 1 commit into from
Aug 31, 2024

Conversation

lmnotran
Copy link
Contributor

ninja is the correct brew package name for the Ninja build system
https://formulae.brew.sh/formula/ninja

romacdon
romacdon approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@romacdon romacdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui merged commit 86395b3 into openthread:main Aug 31, 2024
8 checks passed
@lmnotran lmnotran deleted the bugfix/bootstrap branch August 31, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romacdon romacdon romacdon approved these changes

@jwhui jwhui jwhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmnotran @jwhui @romacdon