Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] update to GSDK 4.4.3 #904

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

lmnotran
Copy link
Contributor

@lmnotran lmnotran commented Jul 2, 2024

No description provided.

Verified

This commit was signed with the committer’s verified signature.
lmnotran Mason Tran
@lmnotran lmnotran marked this pull request as ready for review July 2, 2024 20:19
Copy link
Contributor

@hemanth-silabs hemanth-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


otSysEventSignalPending();
if (timer_data->overflow_counter < timer_data->overflow_max)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I think we can combine the two timer expired callbacks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I also have that as an action item for myself with planned alarm updates for renode support, so please don't duplicate any work!

Copy link
Contributor

@romacdon romacdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmnotran lmnotran requested review from jwhui and removed request for suveshpratapa July 3, 2024 17:14
@jwhui jwhui merged commit ae03498 into openthread:main Jul 3, 2024
8 checks passed
@lmnotran lmnotran deleted the feature/update-to-gsdk-4.4.3 branch July 3, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants