[script] simplify how platform libs are pulled into the CMake build tree #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmnotran
force-pushed
the
feature/build-script-improvements
branch
4 times, most recently
from
b23545b to
83fe4de
Compare
lmnotran
force-pushed
the
feature/build-script-improvements
branch
from
83fe4de to
b5c6e56
Compare
lmnotran
force-pushed
the
feature/build-script-improvements
branch
from
2c8aea0 to
aae6920
Compare
lmnotran
requested review from
hemanth-silabs,
romacdon,
suveshpratapa,
bertoldi-silabs and
parag-silabs
| sdk_dir="${repo_dir}/third_party/silabs/gecko_sdk" | ||
|
|
||
| # Check if repo_dir is defined | ||
| if [ -z ${repo_dir+x} ]; then |
There was a problem hiding this comment.
What is the +x modifier used in ${repo_dir+x} and ${gsdk_dir+x}?
There was a problem hiding this comment.
bertoldi-silabs
approved these changes
May 8, 2024
jwhui
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor script improvements and also minor changes to the CMakeLists.txt file that make it easier for ot-efr32 to be consumed by a different project