Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] update to Gecko SDK 4.3.2 #733

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

lmnotran
Copy link
Contributor

No description provided.

@lmnotran lmnotran changed the title [sdk] update to GSDK 4.3.2 [sdk] update to Gecko SDK 4.3.2 Nov 22, 2023
@lmnotran lmnotran force-pushed the feature/update-to-gsdk4.3.2 branch 2 times, most recently from 2ecb046 to 02f2433 Compare November 22, 2023 17:45
OpenThread stack update change 992be2781->a363396eb (in commit 2c459e3a3) had a change in the stack to clarify and adjust various CSL timing units to existing 802.15.4 standards based timing concepts.

See openthread/openthread@6da6e09

One of the changes was to clarify that the rxTimestamp (used to calculate "next" CSL transmissions) should point to the end of the sync header (SHR). So when scheduling our transmit, we must make sure to subtract the SHR duration value from our base time since this is already accounted for when calculating next CSL transmission delay.

Co-authored-by: Suvesh Pratapa <[email protected]>
@lmnotran lmnotran force-pushed the feature/update-to-gsdk4.3.2 branch from 02f2433 to ff6a489 Compare November 22, 2023 17:51
@lmnotran lmnotran force-pushed the feature/update-to-gsdk4.3.2 branch from ff6a489 to 6740d0c Compare November 22, 2023 17:55
Copy link
Member

@suveshpratapa suveshpratapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@romacdon romacdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmnotran lmnotran requested review from jwhui and removed request for hemanth-silabs and parag-silabs November 27, 2023 21:29
@jwhui
Copy link
Member

jwhui commented Nov 27, 2023

@lmnotran , would you like these commits merged separately? Or squash-merge? If separate, can you include the PR# in the commit header? For example:

[sdk] update to Gecko SDK 4.3.2 (#733)

@lmnotran
Copy link
Contributor Author

lmnotran commented Nov 27, 2023

@jwhui a squash-merge is fine. Thanks for reviewing!

@jwhui jwhui merged commit d57715a into openthread:main Nov 27, 2023
8 checks passed
@lmnotran lmnotran deleted the feature/update-to-gsdk4.3.2 branch November 27, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants