Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] check any raw SWIG wrapper files generated by SWIG #309

Merged
merged 5 commits into from
Dec 10, 2024
Merged

[build] check any raw SWIG wrapper files generated by SWIG #309

merged 5 commits into from
Dec 10, 2024

Conversation

ZhangLe2016
Copy link
Contributor

@ZhangLe2016 ZhangLe2016 commented Dec 6, 2024 •
edited
Loading

To avoid generating raw wrapper files, we perform checks during the build process to prevent this.

@ZhangLe2016 ZhangLe2016 changed the title [swig] Check any errors in the SWIG wrappers [build] Check any raw SWIG wrapper files generated by SWIG Dec 6, 2024
@ZhangLe2016 ZhangLe2016 marked this pull request as ready for review December 10, 2024 02:54
@ZhangLe2016 ZhangLe2016 requested a review from wgtdkp December 10, 2024 02:54
wgtdkp
wgtdkp approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is really useful!

android/build-commissioner-libs.sh Outdated Show resolved Hide resolved
android/build-commissioner-libs.sh Outdated Show resolved Hide resolved
@wgtdkp wgtdkp requested a review from jwhui December 10, 2024 06:09
@jwhui jwhui changed the title [build] Check any raw SWIG wrapper files generated by SWIG [build] check any raw SWIG wrapper files generated by SWIG Dec 10, 2024
@jwhui jwhui merged commit 5cff6d6 into openthread:main Dec 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhui jwhui jwhui approved these changes

@wgtdkp wgtdkp wgtdkp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhangLe2016 @wgtdkp @jwhui