-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] remove the XpanId
and PanId
structs
#264
Conversation
71fd9a4
to
ef31c91
Compare
It's an overkill to define a dedicated class/struct for a simple `uint16_t` just for pretty print to json in HEX string.
ef31c91
to
dbfa960
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 72.88% 72.83% -0.05%
==========================================
Files 72 72
Lines 7500 7476 -24
==========================================
- Hits 5466 5445 -21
+ Misses 2034 2031 -3
|
e840da8
to
5cb6cc8
Compare
@abtink I am not sure if you are willing to review the ot-commissioner changes :) In case no, please feel free to remove yourself from the pending list, I can wait for rongli :) |
XpanId
and PanId
structs
It's an overkill to define a dedicated class/struct for a simple `uint16_t` just for pretty print to json in HEX string.
It's an overkill to define a dedicated class/struct for a simple `uint16_t` just for pretty print to json in HEX string.
It's an overkill to define a dedicated class/struct for a simple
uint16_t
just for pretty print to json in HEX string.
The library interface should prefer native/primitive data types for better
interoperability with other languages such as java and Objective-C
This commit basically reverts the XpanId and PanId changes introduced in #202