[cli] update borderagent discover to allow network interface selection for mDNS binding
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce selection for mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border agent using mDNS, they'll need to choose the specific interface the border agent is bound to. This change introduces a new option for the CLI command `borderagent dicover`. Users can now specify a network interface using the syntax `borderagent discovery <timeout> <network interface>`. The chosen interface will be used for mDNS binding through socket options.
ZhangLe2016
changed the title
wgtdkp
reviewed
Apr 12, 2024
…ce selection for mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border agent using mDNS, they'll need to choose the specific interface the border agent is bound to. This change introduces a new option for the CLI command `borderagent dicover`. Users can now specify a network interface using the syntax `borderagent discovery <timeout> <network interface>`. The chosen interface will be used for mDNS binding through socket options.
wgtdkp
approved these changes
Apr 17, 2024
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
wgtdkp
reviewed
Apr 24, 2024
Co-authored-by: Kangping <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 72.98% 72.91% -0.07%
==========================================
Files 72 72
Lines 7477 7496 +19
==========================================
+ Hits 5457 5466 +9
- Misses 2020 2030 +10
|
Co-authored-by: Kangping <[email protected]>
wgtdkp
reviewed
Apr 25, 2024
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
wgtdkp
reviewed
Apr 25, 2024
Co-authored-by: Kangping <[email protected]>
Co-authored-by: Kangping <[email protected]>
wgtdkp
approved these changes
Apr 25, 2024
jwhui
changed the title
borderagent discover to allow network interface selection for mDNS binding
jwhui
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border agent using mDNS, they'll need to choose the specific interface the border agent is bound to.
This change introduces a new option for the CLI command
borderagent dicover. Users can now specify a network interface using the syntaxborderagent discover <timeout> <network interface>. The chosen interface will be used for mDNS binding through socket options.