Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] add clang-tidy format #252

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[style] add clang-tidy format #252

merged 1 commit into from
Apr 3, 2024

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Apr 2, 2024

Follow openthread clang-tidy formatting and update the source code accordingly.

@wgtdkp wgtdkp force-pushed the clang-tidy branch 4 times, most recently from 4919af1 to 5d3120c Compare April 3, 2024 05:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 92.24138% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 72.95%. Comparing base (7c936cb) to head (3488e0d).

❗ Current head 3488e0d differs from pull request most recent head e870c84. Consider uploading reports for the commit e870c84 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   73.03%   72.95%   -0.08%     
==========================================
  Files          71       72       +1     
  Lines        7484     7477       -7     
==========================================
- Hits         5466     5455      -11     
- Misses       2018     2022       +4     
Files Coverage Δ
include/commissioner/commissioner.hpp 25.00% <ø> (ø)
include/commissioner/error.hpp 100.00% <ø> (ø)
src/app/cli/interpreter.hpp 100.00% <ø> (ø)
src/app/cli/job.hpp 100.00% <ø> (ø)
src/app/cli/job_manager.hpp 100.00% <ø> (ø)
src/app/cli/main.cpp 85.71% <100.00%> (ø)
src/app/cli/security_materials.cpp 69.31% <100.00%> (ø)
src/app/commissioner_app.hpp 100.00% <100.00%> (ø)
src/app/commissioner_app_dummy.cpp 0.00% <ø> (ø)
src/app/commissioner_app_mock.hpp 52.77% <100.00%> (+0.66%) ⬆️
... and 26 more

@wgtdkp wgtdkp force-pushed the clang-tidy branch 10 times, most recently from e870c84 to 4b0f540 Compare April 3, 2024 11:58
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wgtdkp for all the changes/enhancements to the ot-commissioner 👍

@wgtdkp wgtdkp removed the request for review from librasungirl April 3, 2024 16:46
@wgtdkp
Copy link
Member Author

wgtdkp commented Apr 3, 2024

Thanks @wgtdkp for all the changes/enhancements to the ot-commissioner 👍

Thanks for reviewing @abtink !

@jwhui jwhui merged commit 37936d1 into openthread:main Apr 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants