[build] fix issue when executing build-commissioner-libs.sh multiple times
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When developers run the 'build-commissioner-libs.sh' script multiple times, they might see the following error during compiling the libevent: error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations ... In fact, we did not use pip2 in libevent. We can turn it off by using the macro EVENT_HAVE-PIPE2=0
|
@jwhui seems that I cannot add reviewers into this PR, could you please add me into this project as a contributor? thanks. |
|
Better add this to third_party/libevent/CMakeLists.txt: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 71 71
Lines 7420 7421 +1
=======================================
+ Hits 5443 5444 +1
Misses 1977 1977
|
When developers run the 'build-commissioner-libs.sh' script multiple times, they might see the following error during compiling the libevent: error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations ... In fact, we did not use pip2 in libevent. We can turn it off by using the macro EVENT_HAVE-PIPE2=0
wgtdkp
reviewed
Apr 2, 2024
When developers run the 'build-commissioner-libs.sh' script multiple times, they might see the following error during compiling the libevent: error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations ... In fact, we did not use pip2 in libevent. We can turn it off by using the macro EVENT_HAVE-PIPE2=0
librasungirl
changed the title
jwhui
approved these changes
Apr 2, 2024
jwhui
changed the title
build-commissioner-libs.sh multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developers run the 'build-commissioner-libs.sh' script multiple times, they might see the following error during compiling the libevent:
error: call to undeclared function 'pipe2'; ISO C99 and later do not support implicit function declarations ...
In fact, we did not use pip2 in libevent. We can turn it off by using the macro EVENT_HAVE-PIPE2=0