Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] support mbedtls 3.x #249

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Mar 31, 2024

This PR adds support for building with mbedtls 3.x. Specifically:

  1. some mbedtls APIs are removed or renamed in 3.x so that we need to do the migration
  2. fix some fmtlib compile issues, e.g. making enums formattable
  3. we changed to use MBEDTLS_CONFIG_FILE to specify the full configuration instead of leveraging MBEDTLS_USER_CONFIG_FILE on top of the default mbedtls configuration (this is for working around internal building issues)

@wgtdkp wgtdkp marked this pull request as draft March 31, 2024 14:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 33.84615% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 72.98%. Comparing base (f63ec73) to head (7fa9518).

❗ Current head 7fa9518 differs from pull request most recent head ac19086. Consider uploading reports for the commit ac19086 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   73.33%   72.98%   -0.35%     
==========================================
  Files          71       71              
  Lines        7421     7477      +56     
==========================================
+ Hits         5442     5457      +15     
- Misses       1979     2020      +41     
Files Coverage Δ
include/commissioner/error.hpp 100.00% <100.00%> (ø)
src/library/coap.hpp 96.38% <ø> (ø)
src/library/dtls.cpp 82.35% <100.00%> (+0.28%) ⬆️
src/library/dtls.hpp 100.00% <100.00%> (ø)
src/library/openthread/sha256.cpp 100.00% <ø> (ø)
src/library/coap.cpp 60.46% <25.86%> (-3.24%) ⬇️

@wgtdkp wgtdkp force-pushed the update-modules branch 3 times, most recently from 2d57b61 to 3450d49 Compare April 1, 2024 12:46
@wgtdkp wgtdkp changed the title Update modules [build] support mbedtls 3.x Apr 1, 2024
@wgtdkp wgtdkp marked this pull request as ready for review April 1, 2024 12:57
@wgtdkp wgtdkp requested a review from librasungirl April 1, 2024 12:57
@wgtdkp wgtdkp force-pushed the update-modules branch 4 times, most recently from dab686d to ac19086 Compare April 2, 2024 12:44
Support building with mbedtls 3.x which is required for different
platforms.
Copy link
Contributor

@librasungirl librasungirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wgtdkp wgtdkp requested a review from jwhui April 2, 2024 13:19
@jwhui jwhui merged commit c7c1934 into openthread:main Apr 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants