You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation requires the caller of the Commissioner library to set Mesh-Local prefix before
initiating MGMT commands. it is error-prone and breaks backward compatibility: we need to first fetch
the Active Operational Dataset and set the Mesh-Local Prefix to the commissioner library before sending
other MGMT_* commands:
This PR refactors the UDP Proxy to have it manage the Mesh-Local prefix inside the ProxyClient class.
The Mesh-Local prefix is lazily requested from the Border Agent before sending the first MGMT command (if no Mesh-Local prefix is cached).
The cached Mesh-Local prefix is cleared when the commissioner receives MGMT_DATASET_CHANGED.ntf so that the latest Mesh-Local prefix will be fetched before next MGMT command.
The cached Mesh-Local prefix is cleared when the commissioner is disconnected.
In this way, the user doesn't need to be aware of the Mesh-Local prefix and no changes are required.
Merging #188 (c8efa67) into main (f41edbd) will increase coverage by 0.00%.
The diff coverage is 93.33%.
❗ Current head c8efa67 differs from pull request most recent head de34d98. Consider uploading reports for the commit de34d98 to get more accurate results
Merging #188 (257d980) into main (1b5dd47) will increase coverage by 0.97%.
The diff coverage is 93.87%.
❗ Current head 257d980 differs from pull request most recent head d06e7c3. Consider uploading reports for the commit d06e7c3 to get more accurate results
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation requires the caller of the Commissioner library to set Mesh-Local prefix before
initiating
MGMT
commands. it is error-prone and breaks backward compatibility: we need to first fetchthe Active Operational Dataset and set the Mesh-Local Prefix to the commissioner library before sending
other
MGMT_*
commands:ot-commissioner/src/app/commissioner_app.cpp
Lines 151 to 155 in 1b5dd47
This PR refactors the UDP Proxy to have it manage the Mesh-Local prefix inside the
ProxyClient
class.MGMT
command (if no Mesh-Local prefix is cached).MGMT_DATASET_CHANGED.ntf
so that the latest Mesh-Local prefix will be fetched before nextMGMT
command.In this way, the user doesn't need to be aware of the Mesh-Local prefix and no changes are required.