Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] test cancelling requests from CLI #137

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[tests] test cancelling requests from CLI #137

wants to merge 5 commits into from

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Jul 24, 2020

This PR has mainly two changes:

  1. the user now can expect an error for a commissioner command
  2. add an integration tests to verify we can cancel requests with an interrupt signal.

@wgtdkp wgtdkp requested a review from simonlingoogle July 25, 2020 10:57
simonlingoogle
simonlingoogle approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wgtdkp
Copy link
Member Author

wgtdkp commented Jul 26, 2020

This PR depends on #138.

@wgtdkp
Copy link
Member Author

wgtdkp commented Jul 26, 2020

@simonlingoogle I added a new API CancelDiscoverBorderAgent in border_agent.hpp to cancel discovery. Please review.

@wgtdkp wgtdkp requested a review from simonlingoogle July 26, 2020 07:09
simonlingoogle
simonlingoogle approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wgtdkp wgtdkp self-assigned this Jul 29, 2020
Base automatically changed from master to main March 8, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonlingoogle simonlingoogle simonlingoogle approved these changes

Assignees

@wgtdkp wgtdkp

Labels
continuous-integration work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgtdkp @simonlingoogle