[Feat.] DMS: Add new resource opentelekomcloud_dms_topic_v2 #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-lifshits
requested review from
Aloento,
vladimirvshivkov,
anton-sidelnikov and
muneeb-jan
muneeb-jan
previously approved these changes
Dec 13, 2024
anton-sidelnikov
requested changes
Dec 13, 2024
docs/resources/dms_topic_v2.md
Outdated
|
|
||
| The following arguments are supported: | ||
|
|
||
| * `instance_id` - (Required) Indicates the ID of primary DMS instance. |
There was a problem hiding this comment.
please add type and forcenew details
|
|
||
| * `remain_partitions` - Number of remaining partitions. | ||
|
|
||
| * `max_partitions` - Total partitions number. |
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { common.TestAccPreCheck(t) }, | ||
| ProviderFactories: common.TestAccProviderFactories, | ||
| CheckDestroy: testAccCheckDmsV1InstanceDestroy, |
There was a problem hiding this comment.
please use InitResourceCheck
| @@ -10,6 +10,7 @@ const ( | |||
| errCreationClient = "error creating OpenTelekomCloud DMSv1 client: %w" | |||
| errCreationClientV2 = "error creating OpenTelekomCloud DMSv2 client: %w" | |||
| dmsClientV2 = "dms-v2-client" | |||
| dmsV1Deprecated = "This resource API is deprecated. Please use opentelekomcloud_dms_topic_v2 instead." | |||
There was a problem hiding this comment.
also add message in doc
anton-sidelnikov
approved these changes
Dec 16, 2024
|
Build succeeded. ✔️ build-otc-releasenotes SUCCESS in 4m 02s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
New resource
opentelekomcloud_dms_topic_v2introduced.opentelekomcloud_dms_topic_v1is deprecated due to api going out-of-date.PR Checklist
Acceptance Steps Performed