Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Ignore the 'default_branch' option #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix: Ignore the 'default_branch' option #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1b1b79
Bugfix: Ignore the 'default_branch' option
scoopex Nov 20, 2024
aaddcd5
satisfy linting
scoopex Nov 20, 2024
184af17
add warning
scoopex Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion plugins/module_utils/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,12 @@ def request(
error_data[key] = info[key]

error_data["response"] = response or "no response"
error_data["body"] = body or "no body"
error_data["response_body"] = body or "no body"
error_data["request_url"] = url
error_data["request_method"] = method
if 'json' in kwargs:
error_data["request_body"] = kwargs['json'] or 'no body'

self.save_error(f"request failed {error_msg}: {error_data}")
elif status == 404 and ignore_missing:
return None
Expand Down Expand Up @@ -1126,6 +1131,15 @@ def _manage_repository(self, state, current=None, check_mode=False, **kwargs):
owner = kwargs.pop('owner')
repo_name = kwargs.pop('name')
current_repo = current if current else self.get_repo(owner, repo_name, ignore_missing=True)

# When specifying a default branch on a repository which is still empty, the execution
# fails with the following error message:
# 'Cannot update default branch for an empty repository. Please init the repository and push first'
# Therefore we remove this option in that case.
if current_repo['size'] == 0:
del kwargs['default_branch']
scoopex marked this conversation as resolved.
Show resolved Hide resolved
self.ansible.warn(f"Repo {repo_name} does not yet have any branches or commits, cannot set the default branch")

if not current_repo:
changed = True
if not check_mode:
Expand Down