Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(policy): 1435 tech debt migrate attribute definition object queries to sqlc #1450

Merged
merged 14 commits into from
Oct 4, 2024
Merged

feat(policy): 1435 tech debt migrate attribute definition object queries to sqlc #1450

merged 14 commits into from
Oct 4, 2024
+927 −609

Conversation

ryanulit
Copy link
Contributor

@ryanulit ryanulit commented Aug 23, 2024 •
edited
Loading

fix #1435

also implements:

  • architecture decisions per adr readme
  • recent audit improvements

@ryanulit ryanulit linked an issue Aug 23, 2024 that may be closed by this pull request
Migrate Attribute Definition object queries to sqlc #1435
Closed
@jrschumacher jrschumacher added the comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) label Sep 6, 2024
@ryanulit ryanulit marked this pull request as ready for review October 4, 2024 15:29
@ryanulit ryanulit requested review from a team as code owners October 4, 2024 15:29
jakedoublev
jakedoublev previously approved these changes Oct 4, 2024
View reviewed changes
service/policy/db/attributes.go Outdated Show resolved Hide resolved
service/policy/db/attributes.go Outdated Show resolved Hide resolved
service/policy/db/query.sql Outdated Show resolved Hide resolved
jakedoublev
jakedoublev previously approved these changes Oct 4, 2024
View reviewed changes
@ryanulit ryanulit added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit c36624c Oct 4, 2024
20 checks passed
@ryanulit ryanulit deleted the 1435-migrate-attribute-definition-object-queries-to-sqlc branch October 4, 2024 17:36
@opentdf-automation opentdf-automation bot mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakedoublev jakedoublev jakedoublev approved these changes

Assignees
No one assigned
Labels
comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Attribute Definition object queries to sqlc
3 participants
@ryanulit @jakedoublev @jrschumacher