cva dev #593
Closed
cva dev #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers/resvol/main.go:364:7: github.com/opensvc/om3/util/key.T struct literal uses unkeyed fields
One less breaking change, freeing the "dns" object name again, same as b2.1 Also coherent with "om daemon relay status" commande location in the command tree.
coloring functions and icons where renderer before color.noColor is set, so ended up always colored.
Also drop the --config flag.
And move daemon/ccfg.getClusterConfig() to core/cluster.GetConfig(), so it can be called from the CRM too.
So ox can use this func without requiring the object mod.
viper was used to load:
* /etc/{default,sysconfig}/opensvc
for OSVC_ROOT_PATH, OSVC_CLUSTERNAME
=> replace by direct use of gotenv.ParseStrict(), the mod that vipers
imports.
* /etc/cluster.conf
for caching of NodeSection and ClusterSection
=> the daemon already switched to cluster.ConfigData for this caching.
just teach the CRM to use directly object.Ccfg.Config
* ~/.opensvc/config.yaml
for output colors.
=> Use OSVC_COLORS=primary=blue:secondary=yellow env var instead, like
the ls command does.
Related changes:
* rawconfig.LoadSection() is dropped.
* clusternode.Get() is no longer used.
* client.New() does no longer know how to get the cluster secret, so the
caller must set it with the WithPassword() funcopt.
* New resource manifest context keys: ContextObjectFQDN and
ContextObjectDomain.
* nodeselector now only look at the nodes_info.json to find cluster
nodes.
* replace omcrypto.Message type with omcrypto.Factory that implement the
encryptDecrypter interface required by the sec and usr object kinds.
Newer symcli don't accept MB captype anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.