Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon subdaemon refactor #414

Closed
wants to merge 29 commits into from

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    5df95bc View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. [scheduler] Refactor to prepare daemon/subdaemon removal

    daemon components won't anymore embed *subdaemon.T
    cgalibern committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d6f7acb View commit details
    Browse the repository at this point in the history
  2. [hb] Refactor to prepare daemon/subdaemon removal

    daemon components won't anymore embed *subdaemon.T
    cgalibern committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7e2739d View commit details
    Browse the repository at this point in the history
  3. [lsnrhttp{inet,ux}] Refactor to prepare daemon/subdaemon removal

    daemon components won't anymore embed *subdaemon.T
    
    t.Stop() now returns when internal waitGroup is done
    cgalibern committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ef8b5b7 View commit details
    Browse the repository at this point in the history
  4. [listener] Refactor to prepare daemon/subdaemon removal

    daemon components won't anymore embed *subdaemon.T
    
    This commit also removes useless code: loop & httpHandler
    cgalibern committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    de545a5 View commit details
    Browse the repository at this point in the history
  5. [discover] Refactor to prepare daemon/subdaemon removal

    daemon components won't anymore embed *subdaemon.T
    cgalibern committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7db0312 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    563c80c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    21056b3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7faf951 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cc999aa View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    77b3104 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    b786ab6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc42dad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba1deb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. [daemonapi,routehttp] Refactor labelnode -> DaemonApi.LabelNode for test

    DaemonApi has a new LabelNode member that is defined during api.RegisterHandlers
    => mocked hostname value during tests is applied to daemon api used label node
    cgalibern committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    cd83f20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a8b42e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d0b8dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44caffe View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    19ca044 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2e41f42 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    85e4415 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5803471 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a6aeacb View commit details
    Browse the repository at this point in the history
  10. [daemon/hb] Improves start & stop

    Previous implementation has unclear start/stop order.
    
    Now created routines that has its own stop methods will use main t.ctx context:
    - controller
    
    other routines will use a cancelable context, that is cancelled during t.Stop()
    - msgToTx
    - msgFromRx
    - janitor
    - hb drivers
    
    => Stop()
       1- t.cancel() => cancel msgToTx, msgFromRx, janitor, hb drivers
       2- stop started hb drivers
       3- wait for wait group (msgToTx, msgFromRx and janitor are done)
       4- stop the controller
    
    - msgToTx and msgFromRx returns when it detects cancellation while processing message
    cgalibern committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4bcd05d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    50dc1ce View commit details
    Browse the repository at this point in the history
  12. [daemoncli] Close daemonsys when not anymore used

    This stop the associated goroutine
    cgalibern committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2a01cdf View commit details
    Browse the repository at this point in the history
  13. [daemon] Ensure no more routines when daemon is stopped

    ## all components are now managed by the startStopper interface.
    
        - hbcache
        - ccfg
        - cstat
        - istat
    
    ## Stop function now waits for all components done before return.
    
    ## notifyWatchDog functions are now defined in dedicated functions:
    
        - notifyWatchDogSys (for systemd watch dog)
        - notifyWatchDogBus (for pubsub watch dog)
    
    ## use dedicated stopWatcher function to watch for daemon stop requests:
    
        - stop from signal
        - stop from msgbus.DaemonCtl
    
    ## update daemoncli to use Start from daemon instead of RunDaemon
    cgalibern committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    83c4fe0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b05b682 View commit details
    Browse the repository at this point in the history
  15. [test] Make test pass

    cgalibern committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    fddfc4b View commit details
    Browse the repository at this point in the history