Merge freezes on peers happening during agent offline periods #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To not use too much horizontal space in the node columns.
Draining is too alarming because of the ambiguity with the "drain" action, which is a outager.
Also avoid defering the stacking over cancelers when not necessary.
Inherited from the imon original copy.
Instead of creating a new identical pubsub.Label{}.
And emit it from nmon when rejoined, before transitioning nmon state to idle.
Touch a var/last_shutdown file when the nmon routine is canceled. Compare this last_shutdown mtime with the peer nodes FrozenAt, and freeze the node if peer was frozen when we were down. For each object, compare this last_shutdown mtime with the peer instances FrozenAt, and freeze the local instance if the peer instance was frozen when we were down.
If SIGHUP kills the daemon brutally, which is error prone for admins used to SIGHUP being a magic "sync with reality" trigger. Better to ignore it, pending implementation of a reconfiguring handler.
And fix the ordering of daemon/daemon sub routines cancels. Add a sync.WaitGroup to nmon to be able to synchrously wait for its canceling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.