Fix two go vet issues in the kvstore handlers

daemon/daemonapi/get_object_kvstore_keys.go:51:40: github.com/opensvc/om3/util/key.T struct literal uses unkeyed fields daemon/daemonapi/get_object_kvstore_entry.go:53:3: unreachable code
opensvc · Sep 6, 2024 · ea58be3 · ea58be3
1 parent 91e8c6b
commit ea58be3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/daemon/daemonapi/get_object_kvstore_entry.go b/daemon/daemonapi/get_object_kvstore_entry.go
@@ -50,7 +50,6 @@ func (a *DaemonAPI) GetObjectKVStoreEntry(ctx echo.Context, namespace string, ki
 			}
 			return ctx.Blob(http.StatusOK, contentType, b)
 		}
-		return ctx.NoContent(http.StatusNoContent)
 	}
 
 	for nodename := range instanceConfigData {

diff --git a/daemon/daemonapi/get_object_kvstore_keys.go b/daemon/daemonapi/get_object_kvstore_keys.go
@@ -44,11 +44,16 @@ func (a *DaemonAPI) GetObjectKVStoreKeys(ctx echo.Context, namespace string, kin
 		} else {
 			items := make(api.KVStoreKeyListItems, 0)
 			for _, name := range names {
+				configKey := key.T{
+					Section: "data",
+					Option:  name,
+				}
+				size := len(ks.Config().GetString(configKey))
 				items = append(items, api.KVStoreKeyListItem{
 					Object: p.String(),
 					Node:   a.localhost,
 					Key:    name,
-					Size:   len(ks.Config().GetString(key.T{"data", name})),
+					Size:   size,
 				})
 			}
 			return ctx.JSON(http.StatusOK, api.KVStoreKeyList{