-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding extension submission via github action #1407
base: master
Are you sure you want to change the base?
Conversation
I think we should use a more popular action that is battle-tested and maintained, maybe adapt from another extension like Violentmonkey. Actually, I would prefer that we use the web store API directly using a script in our own repository without relying on anything external (other than github's own config for the secrets) because you never know what can happen to third-party code. |
violentmonkey uses https://github.com/violentmonkey/violentmonkey/blob/master/.github/workflows/release.yml#L50 https://github.com/plasmo-corp/bpp/blob/main/pnpm-lock.yaml#L3679
|
See also mozilla/web-ext#804 |
I addressed this issue by using https://github.com/mozilla/sign-addon/ directly for |
00eadf6
to
7963a3a
Compare
6475a2f
to
592047a
Compare
Hi friends,
Thanks for creating stylus, my family and I have been a fan for years. Was looking for some way to contribute, and thought that maybe an automated submission pipeline for the zip archive could be helpful. I created a github action called bpp that can submit the zip to the Chrome/Firefox stores automatically. This PR uses that action for the submission, it is set to run manually from the github action tab, but we can tweak it to run as frequent as needed! The only thing you would need to create is a SUBMIT_KEYS github repository secret.
This secret is a json, with the schema defined here.
Here's a sample key for chrome and firefox:
You can find instructions on how to get those keys in the schema, or if you use vscode, the schema should provide hint/intelisense when hovering over the json properties. If you need any help in setting up the keys, feel free to @ me! Otherwise if this doesn't seem necessary, feel free to close the PR :)