Fix http://trac.openstreetmap.org/ticket/4137 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Also make tram route editor show up on all roads.
makeHTMLIcon(): ${foo|bar|blah} and (${ref}).
(eg http://trac.openstreetmap.org/ticket/4002) A few things to note: 1. I haven't actually tested this, because my local environment doesn't have the real maximise/minimise frame. But I've stepped through the code, and it looks ok. 2. The icon could be prettier. 3. I'm making use of EditController.toggleSize() which was marked private. Someo ne wise should review this. 4. There should probably be some vigorous debate any time a new toolbar icon is added. 5. The button is always enabled, and doesn't change to match state. I tried to make it do that, but I don't know the Flex event stuff well enough. My attempts are included below. I'm committing the alternative state .svg in case it's useful, although it's currently unused. In potlatch2.mxml (button id="fullscreen") toggle="true" selected="{Application.application.theController.isMaximised()}" selectedUpIcon="@embed('embedded/fullscreen-toggle.svg')" selectedDownIcon="@embed('embedded/fullscreen-toggle.svg')" selectedOverIcon="@embed('embedded/fullscreen-toggle.svg')" EditController.isMaximised() [Bindable(event="is_maximised")] public function get isMaximised():Boolean { return maximised; } EditController.toggleSize() { ... dispatchEvent(new Event("is_maximised")); }
…the longest item. Improves appearance and usability.
railway=light_rail construction=tram construction=light_rail construction=subway
openstreetmap-mirror
force-pushed
the
master
branch
2 times, most recently
from
7028063 to
9cab056
Compare
|
This repository is just a mirror. If you'd like to contribute to Potlatch 2 then the main repo is at https://github.com/systemed/potlatch2 and the issue-tracker is at http://trac.openstreetmap.org/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the work was already done, but a typo made it not show up.