-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action deb builder #41
base: master
Are you sure you want to change the base?
Conversation
f984a02
to
6add87c
Compare
Updated comment... it seems the osm-logical plugin in https://github.com/openstreetmap/osmdbt/tree/master/postgresql-plugin is not installed to run some of the unit tests...
|
633524a
to
c03650e
Compare
@Firefishy : we didn't have much success when trying to run all test cases on Ubuntu Launchpad. After compiling the plugin, the build environment wouldn't let us copy osm-logical.so to the respective PostgreSQL directory, see #13 (comment) Here's an old build log: https://launchpadlibrarian.net/610486627/buildlog_ubuntu-jammy-amd64.osmdbt_0.6-jammy1_BUILDING.txt.gz for https://launchpad.net/~mmd-osm/+archive/ubuntu/osmdbt-006/+packages The package on Ubuntu Launchpad was built without unit tests... |
ce7cb2b
to
f6fd0ac
Compare
f6fd0ac
to
508fc7c
Compare
Same here, I disabled the tests in the same way as launchpad and build successfully completed. |
Okay for me. Disabling the test is not ideal but no worse than before. |
FYI: I was able to build packages with unit tests passing for the plugin free fork of the tool (see #38). That’s something to keep in mind, if we plan to do the transition at one point. |
This builds debian packages for Ubuntu 22.04, Ubuntu 24.04 and Debian 12 (bookworm) and creates a draft GitHub release with the deb packages attached.
NOTE: This currently only works with tests disabled. See
debian/rules