Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action deb builder #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Firefishy
Copy link
Member

@Firefishy Firefishy commented Aug 28, 2024

This builds debian packages for Ubuntu 22.04, Ubuntu 24.04 and Debian 12 (bookworm) and creates a draft GitHub release with the deb packages attached.

NOTE: This currently only works with tests disabled. See debian/rules

@mmd-osm
Copy link
Contributor

mmd-osm commented Aug 28, 2024

Updated comment... it seems the osm-logical plugin in https://github.com/openstreetmap/osmdbt/tree/master/postgresql-plugin is not installed to run some of the unit tests...

  3: 2024-08-28 17:48:14.618 UTC [7967] postgres@postgres ERROR:  could not access file "osm-logical": No such file or directory
  3: 2024-08-28 17:48:14.618 UTC [7967] postgres@postgres STATEMENT:  SELECT * FROM pg_create_logical_replication_slot($1, 'osm-logical');

@Firefishy Firefishy force-pushed the add-debian-builder branch 2 times, most recently from 633524a to c03650e Compare August 28, 2024 18:01
@mmd-osm
Copy link
Contributor

mmd-osm commented Aug 28, 2024

@Firefishy : we didn't have much success when trying to run all test cases on Ubuntu Launchpad. After compiling the plugin, the build environment wouldn't let us copy osm-logical.so to the respective PostgreSQL directory, see #13 (comment)

Here's an old build log: https://launchpadlibrarian.net/610486627/buildlog_ubuntu-jammy-amd64.osmdbt_0.6-jammy1_BUILDING.txt.gz for https://launchpad.net/~mmd-osm/+archive/ubuntu/osmdbt-006/+packages

The package on Ubuntu Launchpad was built without unit tests...

@Firefishy Firefishy force-pushed the add-debian-builder branch 2 times, most recently from ce7cb2b to f6fd0ac Compare August 28, 2024 21:28
@Firefishy
Copy link
Member Author

The package on Ubuntu Launchpad was built without unit tests...

Same here, I disabled the tests in the same way as launchpad and build successfully completed.

@Firefishy Firefishy marked this pull request as ready for review August 28, 2024 22:05
@joto
Copy link
Collaborator

joto commented Aug 29, 2024

Okay for me. Disabling the test is not ideal but no worse than before.

@mmd-osm
Copy link
Contributor

mmd-osm commented Aug 30, 2024

FYI: I was able to build packages with unit tests passing for the plugin free fork of the tool (see #38). That’s something to keep in mind, if we plan to do the transition at one point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants