Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar, card, other UI adjustments #213

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Navbar, card, other UI adjustments #213

wants to merge 5 commits into from

Conversation

Ancymonek
Copy link
Contributor

Navbar, card, other UI adjustments

  • allow download only countries with > 0 AEDs

Not tested as logged in user (cannot set up)

Copy link
Member

@starsep starsep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested as logged in user (cannot set up)

That's fine - it works the same way regardless.

Language picker is cut off for longer language names
image
image
image

@starsep
Copy link
Member

starsep commented Feb 21, 2024

Language picker is cut off for longer language names

Actually it is already cut off.
image
image
image

After PR it happens for even shorter language names

@Ancymonek
Copy link
Contributor Author

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:
obraz

But there still be issue for lang code like Zh-Hans..

@starsep
Copy link
Member

starsep commented Feb 21, 2024

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:

I think it's a good idea.

Regarding Chinese (both tradition and simplified) I think it should be possible to fit in two characters.
Current names have 4 characters:

    "zh-Hans": { nativeName: "简体中文" },
    "zh-Hant": { nativeName: "繁体中文" },

What do you think? @LaoshuBaby @Supaplextw @s8321414

@s8321414
Copy link
Contributor

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:

I think it's a good idea.

Regarding Chinese (both tradition and simplified) I think it should be possible to fit in two characters. Current names have 4 characters:

    "zh-Hans": { nativeName: "简体中文" },
    "zh-Hant": { nativeName: "繁体中文" },

What do you think? @LaoshuBaby @Supaplextw @s8321414

It should be "简体中文" for zh-Hans and "繁體中文" for zh-Hant I think.

@LaoshuBaby
Copy link
Contributor

I was thinking about it - some solution is that we can display only codes of languages in the navbar and full name + code when navbar is expanded:

I think it's a good idea.

Regarding Chinese (both tradition and simplified) I think it should be possible to fit in two characters. Current names have 4 characters:

I have no problem with using language codes to represent Simplified and Traditional Chinese, it depends on the technical choices of the project. (Because name:zh-Hans and name:zh-Hant are used in OSM data)

@danieldegroot2 danieldegroot2 added the enhancement New feature or request label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants