Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used decaffeinate to convert coffeescript into javascript #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phapdinh
Copy link

Hi @sorccu I started on the conversion of the coffeescript files into javascript. I don't know if every conversion is valid, but I am open to helping out as much as I can.

@sorccu
Copy link
Member

sorccu commented Sep 20, 2019

I appreciate the effort but I’m hoping for a better conversion than just running decaffeinate and calling it a day. At least the decaf suggestions should be addressed.

@sorccu
Copy link
Member

sorccu commented Sep 20, 2019

And the coffeescript dependency and build scripts should be removed.

There is an older branch where this was attempted. You can look at that for reference.

@phapdinh
Copy link
Author

I can take the javascript files that are generated from grunt and replace the coffeescript files with those files instead of using decaffeinate. Those javascript files are what are actually used in production

@phapdinh
Copy link
Author

I can create a separate PR for that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants