Catch param case sensitivity on PA vote parsing #5105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there this is my first PR on this project so lmk if I'm doing something wrong here!
I noticed during running scraping for PA that it seems there can be times where the roll call votes include "sessYr" but it looks like we are looking for "sessyr", and thus we don't see it and attempt to add it, leading to a 404.
Example of log output from the scraper:
Seems like we attempted to work around this with a recent PR here: #5086
I'm wondering if they added this onto links on the server side but they added it in a different format.
According to the RFC rfc7230 query params are actually case sensitive so I'm proposing we check for things in lowercase first, and if it does not exist then we add it in the case that the PA site seems to want there.