Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to customize the number of manilaAPI processes #371

Closed
wants to merge 1 commit into from

Conversation

fmount
Copy link
Collaborator

@fmount fmount commented Dec 5, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from abays and viroel December 5, 2024 08:07
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Collaborator Author

fmount commented Dec 5, 2024

/test manila-operator-build-deploy-kuttl

@@ -672,6 +672,11 @@ spec:
caBundleSecretName:
type: string
type: object
workers:
default: 3
Copy link
Collaborator Author

@fmount fmount Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gouthampacha is this a good "default" ? Do we want to stay w/ 4 (the original hardcoded value), or do we want something else?
Restored 4 as default. Do we want a different value?

@stuggi
Copy link
Contributor

stuggi commented Dec 5, 2024

I am against adding a parameter for something you can use the custom config way to set it. we do not want to introduce tht params

@stuggi
Copy link
Contributor

stuggi commented Dec 5, 2024

I am against adding a parameter for something you can use the custom config way to set it. we do not want to introduce tht params

ok, wait this is different. this is for httpd customization

@stuggi
Copy link
Contributor

stuggi commented Dec 5, 2024

form httpd tuning, check this keystone PR openstack-k8s-operators/keystone-operator#500 . we should do the same here

@fmount fmount force-pushed the workers branch 2 times, most recently from 14b46b2 to 55cc6a9 Compare December 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants